-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: add windows-mcp marketplace example configuration #7614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Created marketplace-examples directory for MCP server submissions - Added windows-mcp.yaml with complete configuration following marketplace schema - Included multiple installation methods (uvx, pip, development) - Added comprehensive documentation explaining marketplace submission process - Addresses #7613 by providing reference configuration for windows-mcp This example can be used by maintainers to add windows-mcp to the marketplace backend API.
|
|
||
| ## Purpose | ||
|
|
||
| Since the Roo Code Marketplace items are managed through an external API (`https://api.roocode.com/api/marketplace/`), this directory serves as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider clarifying API endpoint URLs: The README mentions https://api.roocode.com/api/marketplace/ while later it refers to https://api.roocode.com/api/marketplace/mcps. Ensure consistency if they are intended to be the same.
| Since the Roo Code Marketplace items are managed through an external API (`https://api.roocode.com/api/marketplace/`), this directory serves as: | |
| Since the Roo Code Marketplace items are managed through an external API (`https://api.roocode.com/api/marketplace/mcps`), this directory serves as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing my own code is like debugging in a mirror - everything looks backwards but the bugs are still mine.
| - pip package manager | ||
|
|
||
| # Installation methods for different scenarios | ||
| content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure here doesn't quite match the schema defined in packages/types/src/marketplace.ts. According to the schema, when using multiple installation methods, each method's content field should be a string containing the JSON configuration. However, I see prerequisites nested under each installation method, which should actually be at the root level for the entire MCP server.
Could we restructure this to match the expected format? The prerequisites at line 18-21 are correct for the root level, but lines 32-33, 42-43, and 54-56 should be removed since prerequisites per installation method aren't supported by the schema.
| content: | | ||
| { | ||
| "command": "uvx", | ||
| "args": ["--from", "windows-mcp", "windows-mcp"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional that we're using windows-mcp as the package name for uvx? The actual package might not exist on PyPI yet. Consider adding a comment clarifying this is an example configuration and the actual package availability should be verified.
|
|
||
| ## MCP Server Configuration Format | ||
|
|
||
| MCP server configurations follow the schema defined in `packages/types/src/marketplace.ts`. Each configuration should include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a note here mentioning that the type field would be added programmatically when these configurations are processed? According to the schema, the type discriminator is added during processing, not in the YAML files themselves.
|
|
||
| 1. Follow the existing format and structure | ||
| 2. Ensure all required fields are present | ||
| 3. Test the installation instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a section about validation here. It would be helpful to document how contributors can validate their example configurations against the TypeScript schema before submission. Perhaps we could add a simple validation script or at least point to the schema location?
Description
This PR attempts to address Issue #7613 by providing a reference configuration for adding windows-mcp to the MCP Marketplace.
Context
After investigating the codebase, I discovered that MCP servers are fetched from a remote API endpoint rather than being stored in this repository. The marketplace items are managed externally through the backend API.
Changes
Purpose
This example configuration can be used by maintainers to:
Related Issue
Closes #7613
Notes
Important
Adds Windows MCP example configuration to
marketplace-exampleswith documentation for marketplace submissions.marketplace-examples/mcp-servers/windows-mcp.yamlwith a complete configuration for Windows MCP.marketplace-examples/README.mdto document the marketplace submission process and configuration format.marketplace-examplesdirectory.This description was created by
for b94a85f. You can customize this summary. It will automatically update as commits are pushed.